summaryrefslogtreecommitdiffstats
path: root/tdeioslave
Commit message (Collapse)AuthorAgeFilesLines
* tdeioslave/sftp: save/restore seqNr for multi-factor authAlexander Golubev2024-03-042-6/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In case the server is set up for multi-factor authentication we could be have to query several things from the user like password, a key passphrase, their mother's maiden name etc. It doesn't make a big difference during an initial connection, but it butchers the reconnection process: it can retrieve the answer of the user to the first question (e.g. their password), but it fails to retrieve the second one (e.g. the key passphrase). So the user would be forced to reenter the answer for the second question upon each reconnection. The reason for this is the passwdserver's desig (see DESIGN [1]): Each query for AuthInfo with the openPassDlg() has an secNr number associated with it. If it's smaller than the one of the one stored for the privious request, than the one from the cache will be returned automagically, if it's bigger the dialog will be prompted to the user. Each call to openPassDlg() advances s_seqNr to the last value reported by the passwdserver. So the first call will return the cached value and subsequent calls will actually display the dialog to the user (assuming authentication with the cached data failed). But in case of multi-factor auth we have to query user for several independent values. And we want to try to retrieve each one of those from the cache. So we have to get a bit hacky and manually manipulate the SlaveBase::s_seqNr value. [1]: https://mirror.git.trinitydesktop.org/gitea/TDE/tdelibs/src/branch/master/tdeio/kpasswdserver/DESIGN Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: imbue error messages with errors from libsshAlexander Golubev2024-03-042-15/+28
| | | | Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: cache passwords in case they were passed to setHost()Alexander Golubev2024-03-041-7/+23
| | | | Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: prevent infinite looping in kb-interactive authAlexander Golubev2024-03-041-0/+12
| | | | Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: purge password in the destructorAlexander Golubev2024-03-041-0/+2
| | | | | | | This could be useful in case the destructor will be called before openConnection() Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: enable changing user during kb-interactive authAlexander Golubev2024-03-041-3/+15
| | | | Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: pass correct username to openPassDlg()Alexander Golubev2024-03-042-12/+30
| | | | | | | | | | | | We should always pass to the openPassDlg() exactly the same username otherwise it may result in incorrect caching of passwords especially in case if the username is changed by the user. Also don't allow username change in case it was passed to setHost() (i.e. it was specified in the URL like e.g. sftp://username@host/). In such a case after changing it'd be impossible to properly cache it. Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: even bigger authentication overhaulAlexander Golubev2024-03-042-162/+326
| | | | | | | | | - Move authentication methods into separate functions so it would be easier to correctly handle error after those and select which should be called in which order. - A lot of minor improvements along the way Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: use realmValue to distinguish different promptsAlexander Golubev2024-03-042-24/+20
| | | | | | | | | | This will help kpasswdserver not to confuse different user's answers to different questions. Also avoid passing/returning TDE::AuthInfo for kb-interactive auth as it isn't really necessary when we don't manually caching passwords anymore. Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: avoid explicit password cachingAlexander Golubev2024-03-042-16/+5
| | | | | | | All password caching we need actually already autmagically done by openPassDlg(). Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: use a scope guards to close connectionAlexander Golubev2024-03-041-17/+14
| | | | | | | | There were a couple of missing closeConnection() calls after connection errors. The probably haven't caused any major bugs, but use scope guards to be on the safe side. Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: split off connection init to a dedicated functionAlexander Golubev2024-03-042-61/+75
| | | | Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: use free to destroy mCallbacksAlexander Golubev2024-03-041-1/+1
| | | | | | As it allocated via malloc() rather than new. Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: overhaul publickey authAlexander Golubev2024-03-042-78/+196
| | | | | | | | | | | | | | | | Several enhancements to public key authentication and some other stuff: - Fix passphrase entry for encrypted keys (was either hanging up or segfaulting) - Use scope guard idiom for cleanup calls for more reliable cleanup in case of errors - Add normal prompt for public key's passphrase entry dialog - Correctly differentiate passphrase to password when cached (yes they are getting cached regardless of keepPassword, at least for some duration of time) - Centrilize AuthInfo initialization and some rejig of it kbd-interactive authentification Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* tdeioslave/sftp: fix keyboard-interactive authenticationAlexander Golubev2024-03-041-43/+85
| | | | | | | | This is a partial fix to the sftp ioslave. Subsequent commits will fix other issues. Closes: https://mirror.git.trinitydesktop.org/gitea/TDE/tdebase/issues/443 Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* Replace Q_WS_* defines with TQ_WS_* equivalentsMichele Calgaro2024-02-141-2/+2
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Replace Q_SIGNALS and Q_SLOTSMichele Calgaro2024-02-031-4/+4
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Replace auto_ptrMichele Calgaro2024-01-211-3/+2
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Use new TQ_METHOD, TQ_SIGNAL, TQ_SLOT definesMichele Calgaro2024-01-1635-191/+191
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Remove usage of TDEDiskDeviceStatus::HotpluggableMichele Calgaro2023-12-281-4/+3
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Replace various '#define' strings - part 6Michele Calgaro2023-12-261-1/+1
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Make dependency upon libssh optionalAlexander Golubev2023-12-251-1/+1
| | | | Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
* Replaced various '#define' with actual strings - part 4Michele Calgaro2023-11-261-1/+1
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Replaced various '#define' with actual strings - part 3Michele Calgaro2023-11-241-1/+1
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Replace Qt with TQtMichele Calgaro2023-11-136-8/+8
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Replace QObject, QWidget, QImage, QPair, QRgb, QColor, QChar, QString, ↵Michele Calgaro2023-09-258-9/+9
| | | | | | QIODevice with TQ* version Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Replace various Q_* and QT_* defines with TQ_* and TQT_*Michele Calgaro2023-09-061-4/+4
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Drop USE_TQT4 codeMichele Calgaro2023-08-272-5/+3
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Drop TQT_TQ*_OBJECT definesMichele Calgaro2023-08-081-1/+1
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Replace Q_OBJECT with TQ_OBJECTMichele Calgaro2023-07-2039-41/+41
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Replace _OBJECT_NAME_STRING defines with actual strings. This relates to the ↵Michele Calgaro2023-07-131-1/+1
| | | | | | merging of tqtinterface with tqt3. Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* SunOS specific patchesDenis Kozadaev2023-05-221-2/+6
| | | | Signed-off-by: Denis Kozadaev <denis@dilos.org>
* hwmanager: use alphabetically sorted menus in tdehwdevicetray.Michele Calgaro2023-03-131-0/+1
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* tdeioslave mediamanager: show the device node in the label also for ↵Michele Calgaro2023-03-121-3/+3
| | | | | | removable drives and CD/DVD disks. Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* SFTP: compatibility with older libssh versionsMavridis Philippe2022-07-152-6/+40
| | | | | Signed-off-by: Mavridis Philippe <mavridisf@gmail.com> Signed-off-by: Slávek Banko <slavek.banko@axis.cz>
* SFTP: Various fixes and improvementsMavridis Philippe2022-07-155-92/+154
| | | | | | | | | | | For details see PR #279. Portions of code borrowed from KDE5 SFTP ioslave: Source: https://invent.kde.org/network/kio-extras/-/blob/master/sftp/kio_sftp.cpp Licence: LGPLv2 or later Signed-off-by: Mavridis Philippe <mavridisf@gmail.com>
* Replaced old sftp ioslave with backported versionMavridis Philippe2022-07-1520-5431/+1518
| | | | | | | | | Source: https://github.com/sandsmark/kde2-kio-sftp-kde4 Licence: GPLv2 or later This resolves issue #276. Signed-off-by: Mavridis Philippe <mavridisf@gmail.com>
* FISH: Security fix backport from KDEMavridis Philippe2022-06-271-1/+3
| | | | | | | | | | | | "Only store password in KWallet if the user asked for it" https://invent.kde.org/network/kio-extras/-/commit/d813cef3cecdec9af1532a40d677a203ff979145 Author: David Faure Licence: GPLv2 This mitigates CVE-2020-12755. Signed-off-by: Mavridis Philippe <mavridisf@gmail.com>
* tdeio-man: add TDE specific man folder to the list of the search paths.Michele Calgaro2022-05-131-0/+1
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Add 'safeRemove' and 'safeRemoveByNode' to mediamanager DCOP interface.Michele Calgaro2022-03-276-82/+56
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* hwmanager: use tdeio_media_mounthelper process toMichele Calgaro2022-03-261-0/+2
| | | | | | | | mount/unmout/lock/unlock/ejct media devices. This ensures a consistent media device status also with complex partition structures and LUKS encryption. Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* tdeio media: add releaseHolders parameter to lock/lockByNode dcop calls.Michele Calgaro2022-03-236-46/+87
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* mediamanager: fix name of available backends in error messages.Michele Calgaro2022-03-061-2/+2
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Added 'eject' and 'ejectByNode' to mediamanager DCOP interface.Michele Calgaro2022-02-196-119/+133
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Removed HAL dependant code.Michele Calgaro2022-02-1414-2579/+27
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Updated after changes to tdehw lib related to device notificaitons.Michele Calgaro2021-08-151-2/+1
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* medianotifier: add medium name and url to notification dialog.Michele Calgaro2021-07-191-5/+6
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Respect build option WITH_TDEHWLIB, otherwise it can lead to FTBFS in ↵Slávek Banko2021-05-184-4/+14
| | | | | | special cases. Signed-off-by: Slávek Banko <slavek.banko@axis.cz>
* tdeioslave media: fixed wrong action in media unlock desktop file.Michele Calgaro2021-05-091-1/+0
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
* Fixed FTBFS when building without tdehw but using HAL.Michele Calgaro2021-05-081-12/+15
| | | | Signed-off-by: Michele Calgaro <michele.calgaro@yahoo.it>
generated by cgit v1.2.1 (git 2.18.0) at 2024-12-22 22:55:23 +0000