From f34601e77a6960ffe67bef5436063fe3605987c6 Mon Sep 17 00:00:00 2001 From: Alexander Golubev Date: Thu, 15 Feb 2024 22:22:35 +0300 Subject: tdeio/kdirlister: add some cleanups for LocalURLJob's Theoretically the lack of those could lead to segfaults and data corruptions, hard to debug but very rare. Signed-off-by: Alexander Golubev --- tdeio/tdeio/kdirlister.cpp | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/tdeio/tdeio/kdirlister.cpp b/tdeio/tdeio/kdirlister.cpp index bcebb93ee..c3fa3d451 100644 --- a/tdeio/tdeio/kdirlister.cpp +++ b/tdeio/tdeio/kdirlister.cpp @@ -1998,6 +1998,11 @@ void KDirLister::stop() { kdDebug(7003) << k_funcinfo << endl; s_pCache->stop( this ); + for( auto it = d->openURLContext.begin(); it != d->openURLContext.end(); ++it ) { + it.key()->disconnect( this ); + it.key()->kill(); + } + d->openURLContext.clear(); d->m_referenceURLMap.clear(); } @@ -2005,6 +2010,17 @@ void KDirLister::stop( const KURL& _url ) { kdDebug(7003) << k_funcinfo << _url.prettyURL() << endl; s_pCache->stop( this, _url ); + TQPtrList toRemove; + for( auto it = d->openURLContext.begin(); it != d->openURLContext.end(); ++it ) { + if( it.data().url ==_url ) { + it.key()->disconnect( this ); + it.key()->kill(); + toRemove.append(it.key()); + } + } + for(const auto &job: toRemove) { + d->openURLContext.remove(job); + } d->m_referenceURLMap.remove(_url.url()); } -- cgit v1.2.1