From c84d8d813c97c6d9f518bd77a4cf2a99b01a12a0 Mon Sep 17 00:00:00 2001 From: Jay Carlson Date: Fri, 27 Mar 2015 11:22:13 -0400 Subject: Avoid divide-by-zero in raw encoding (OSX RealVNC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit OS X RealVNC server crashes out Remmina because the server can provoke bytesPerLine to be zero. Assume this is coding for zero lines. The condition could be checked before the calculation of bytesPerLine. I don’t understand the preconditions of this code to say one way or the other. --- krdc/vnc/rfbproto.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'krdc') diff --git a/krdc/vnc/rfbproto.c b/krdc/vnc/rfbproto.c index 587e9d1c..82aa9af2 100644 --- a/krdc/vnc/rfbproto.c +++ b/krdc/vnc/rfbproto.c @@ -982,7 +982,10 @@ HandleRFBServerMessage() case rfbEncodingRaw: bytesPerLine = rect.r.w * myFormat.bitsPerPixel / 8; - linesToRead = BUFFER_SIZE / bytesPerLine; + /* RealVNC 4.x-5.x on OSX can induce bytesPerLine==0, + usually during GPU accel. */ + /* Regardless of cause, do not divide by zero. */ + linesToRead = bytesPerLine ? (BUFFER_SIZE / bytesPerLine) : 0; while (rect.r.h > 0) { if (linesToRead > rect.r.h) -- cgit v1.2.1