summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| | * Convert coding style from Open Document to MarkdownPavel Roskin2016-02-113-1/+197
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Markdown is easily readable in text editors. Unlike ODT, markdown can be patched. GitHub shows markdown with pretty formatting. Remove bad examples. Improve explanations for good examples. Use Unicode finger sign to work around the issue of code block after a list. Make coding_style.md distributable.
| * | Merge pull request #319 from proski/miscItamar Reis Peixoto2016-02-1328-78/+86
| |\ \ | | | | | | | | Miscellaneous minor patches, mostly for the build system
| | * | Stop redefining libdir, use moduledir for ${libdir}/xrdpPavel Roskin2016-02-1214-15/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | libdir is for shared and static libraries. Some xrdp libraries are loaded dynamically from a non-standard directory, so they are used like modules. Having separate libdir and moduledir would eventually allow to separate dynamically loaded modules from shared libraries.
| | * | Don't ignore files known to gitPavel Roskin2016-02-126-11/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | That can cause unexpected behavior, especially with third party tools. The ignored files will be lost if the source tree is re-imported to another git repository, unless special care is taken. Whitelist all non-generated makefiles. To whitelist instfiles/pam.d/xrdp-sesman, add path to all generated executables listed in the top-level .gitignore, sort .gitignore alphabetically. Add mkinstalldir, it's used by Automake on some systems.
| | * | Fix sloppy formatting in instfiles/Makefile.amPavel Roskin2016-02-121-14/+14
| | | | | | | | | | | | Use spaces around = and +=, indent by 2 spaces.
| | * | Automake 1.7.2 is the oldest version working with xrdpPavel Roskin2016-02-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Automake 1.6.x cannot deal with conditional EXTRA_LIBS. Automake 1.7 and 1.7.1 cannot deal with line continuation in SUBDIRS. It is important to have correct requirements to know what Automake features can be used.
| | * | Use silent rules by default if supported by AutomakePavel Roskin2016-02-121-0/+3
| | | | | | | | | | | | Silent rules make warnings stand out, so they are fixed early.
| | * | Add missing spaces in the strings that are split for line wrappingPavel Roskin2016-02-126-8/+8
| | | |
| | * | xcon: include unistd.h, it's needed for select() on MacOSPavel Roskin2016-02-121-0/+1
| | | |
| | * | startwm.sh: make sure sourced scripts are readablePavel Roskin2016-02-121-29/+26
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | Strictly speaking, both existence and readability should be checked. However, chances of ~/.profile being a directory or a FIFO are very small compared to its chances of being non-readable due to some misconfiguration. Put "if" and "then" on the same line for consistency with other checks. Improve comment and pseudocode formatting.
* | | common: fix for key generated smaller than asked forJay Sorg2016-02-221-12/+20
|/ /
* | sesman: add missing breakJay Sorg2016-02-111-1/+1
|/
* remove duplicated call to scp_session_set_bppItamar Reis Peixoto2016-02-111-1/+0
|
* Merge pull request #316 from proski/32bppItamar Reis Peixoto2016-02-114-7/+29
|\ | | | | Make it possible to use Xvnc with 32 bpp
| * vnc: enable 32 bpp support for Xvnc, it actually worksPavel Roskin2016-02-101-6/+12
| |
| * Allow sessions with 32 bppPavel Roskin2016-02-101-0/+1
| |
| * Check return value of scp_session_set_bpp()Pavel Roskin2016-02-102-1/+16
|/
* Merge pull request #315 from proski/autotoolsItamar Reis Peixoto2016-02-101-1/+1
|\ | | | | Hot fix for recent autotools changes
| * Use AC_CONFIG_MACRO_DIR, not AC_CONFIG_MACRO_DIRSPavel Roskin2016-02-101-1/+1
|/ | | | | | AC_CONFIG_MACRO_DIRS requires a very recent Automake, much newer than the declared version 1.6 (even 1.11 doesn't work). AC_CONFIG_MACRO_DIR is defined by Autoconf starting with version 2.58, so it's within the currently declared constraints.
* common: updates for file.cJay Sorg2016-02-091-23/+32
|
* Merge pull request #273 from gschwind/develjsorg712016-02-081-75/+48
|\ | | | | fix wrong handle of commented section in configuration file.
| * fix wrong handle of commented section in configuration file.Benoit Gschwind2015-08-191-75/+48
| | | | | | | | | | | | | | | | | | - fix parssing of commented section like the line: #[section_name] or ![section_name] - add few comments - improve redability
* | Merge pull request #310 from noldor/develItamar Reis Peixoto2016-02-084-64/+64
|\ \ | | | | | | update japanese keyboard "Henkan_Mode" key and "Muhenkan" key
| * | update japanese keyboard "Henkan_Mode" key and "Muhenkan" keynoldor2016-01-304-64/+64
| | |
* | | Merge pull request #254 from metalefty/freebsd/ipv6Itamar Reis Peixoto2016-02-082-8/+16
|\ \ \ | | | | | | | | Unbreak IPv6 on FreeBSD and add IPv6-only option
| * | | common: add --enable-ipv6only optionKoichiro IWAO2015-07-022-0/+13
| | | |
| * | | common: drop ipv6 autodetection only valid for linuxKoichiro IWAO2015-07-022-8/+3
| | | |
* | | | Merge pull request #309 from proski/develItamar Reis Peixoto2016-02-0852-138/+137
|\ \ \ \ | | | | | | | | | | Fixes for autotools, compile warnings and MacOS compatibility
| * | | | Don't capitalize "Error" and print the error valuePavel Roskin2016-02-071-1/+2
| | | | |
| * | | | Spell "return value", not "returnvalue"Pavel Roskin2016-02-071-1/+1
| | | | |
| * | | | Change an unconditional #warning to a commentPavel Roskin2016-01-311-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | Notes about software design should not be shown as warnings to everybody who compiles the code. Warnings should be about unexpected conditions detected at the compile time.
| * | | | xcon: include sys/types.h for select() and related macrosPavel Roskin2016-01-311-0/+1
| | | | |
| * | | | rail: fix declaration of rail_desktop_resize()Pavel Roskin2016-01-311-1/+1
| | | | | | | | | | | | | | | | | | | | Arguments without a type default to int. The caller passes a pointer to XEvent, so use that type.
| * | | | Declare xrdp_mm_frame_ack() in xrdp.h, it's used in xrdp_wm.cPavel Roskin2016-01-311-0/+2
| | | | |
| * | | | clipboard: undefine previously defined log levelPavel Roskin2016-01-301-0/+2
| | | | |
| * | | | More spelling fixes found by codespell and aspellPavel Roskin2016-01-3010-17/+17
| | | | |
| * | | | Replace "charactor" with "character" everywherePavel Roskin2016-01-3012-27/+27
| | | | |
| * | | | xrdpapi: fix MacOS compilation - use SO_NOSIGPIPE instead of MSG_NOSIGNALPavel Roskin2016-01-301-0/+13
| | | | |
| * | | | Use standard autotools means to detect X11Pavel Roskin2016-01-304-9/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use AC_PATH_XTRA to search for X11 in configure.ac. In Makefiles, add X_CFLAGS to AM_CFLAGS for the source compilation. Add X_LIBS to LDFLAGS. Add X_PRE_LIBS and X_EXTRA_LIBS to LDADD. With this patch, X Windows system is correctly detected on Mac OS X.
| * | | | clipboard_file: include sys/time.h for struct timeval, needed on Mac OS XPavel Roskin2016-01-301-0/+1
| | | | |
| * | | | Disable systemd support for "make distcheck"Pavel Roskin2016-01-291-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | "make distcheck" sets prefix to a user-owned directory, compiles code and runs "make install". That fails if systemd files need to be installed, as their location if not relative to the prefix.
| * | | | Don't touch any files in bootstrapPavel Roskin2016-01-291-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | configure.ac already exists. Its timestamp doesn't need to be updated. autoreconf takes care of the timestamps. Since "foreign" is used in Makefile.am, no standard GNU files are required. Distributing empty files like README could be disappointing for the users.
| * | | | Create the m4 directory for Autoconf macro filesPavel Roskin2016-01-293-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Keeping separate files is more maintainable than merging them into a single aclocal.m4 file. It is easier for users to understand where those files come from. Automake knows how to distribute files in the m4 directory.
| * | | | Merge AM_CFLAGS and INCLUDES info AM_CPPFLAGSPavel Roskin2016-01-2916-61/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | AM_CPPFLAGS is for flags passed to the preprocessor, such as defines and includes. AM_CFLAGS is for flags affecting the compiler, such as debug and optimization settings. INCLUDES is an obsolete name. Users can pass INCLUDES and break compilation. AM_CPPFLAGS is more explicit that the flags come from Automake and should not be overridden.
| * | | | Don't use a symlink where #include would sufficePavel Roskin2016-01-263-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Absolute symlinks break when the source is moved to another location. In the best case, the symlink will be replaced with a copy, but that creates code duplication. A user who got the packaged source may decide to change one config.c without realizing that another config.c will get the same changes. Don't ignore config.c, it's a regular source file now, albeit very short. Testing done: compiled inside and outside build directory.
| * | | | Remove GOT_PREFIX, it's a broken hack of limited utilityPavel Roskin2016-01-263-12/+0
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To add flags to the compiler, CFLAGS, CPPFLAGS or LDFLAGS can be used on the configure command line. The need to add flags depends on the location of the headers and libraries of the dependencies, which is orthogonal to the directory where xrdp will be installed. The implementation in configure.ac has a stray closing bracket, making GOT_PREFIX true even if --prefix is not passed. The implementation is inconsistent - the only affected makefiles are for xrdp and libxrdp. Changing rpath manually is wrong in most cases. Libtool should be able to set rpath correctly on its own. Using $(prefix)/lib ignores the libdir setting. For many 64-bit systems, /usr/lib is used for 32-bit libraries. Adding 32-bit libraries to the rpath slows down 64-bit executables, as the dynamic loader searches for libraries in a wrong directory. There is no way to disable GOT_PREFIX if --prefix has to be passed. Fedora RPM patches configure.ac and needs to rerun autoconf and automake after that.
* | | | Merge pull request #314 from proski/localeItamar Reis Peixoto2016-02-081-1/+0
|\ \ \ \ | |/ / / |/| | | sesman: don't set LANG, let initialization scripts take care of it
| * | | sesman: don't set LANG, let initialization scripts take care of itPavel Roskin2016-02-071-1/+0
|/ / / | | | | | | | | | | | | | | | Setting LANG to en_US.UTF-8 suppresses language settings from /etc/locale.conf See https://bugzilla.redhat.com/show_bug.cgi?id=1290820
* | | Merge pull request #306 from metalefty/fontconfig-disable-docsjsorg712016-01-241-1/+1
|\ \ \ | | | | | | | | X11rdp: disable fontconfig docs
| * | | X11rdp: disable fontconfig docsKoichiro IWAO2016-01-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | as it rarely fails to build. Nobody actually needs fontconfig docs to build and run x11rdp even if it builds successfully. Thus we can just disable it.