| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Warning fixes
|
| | |
|
| |
| |
| | |
Use of tabs is fixed as well.
|
| | |
|
| | |
|
|/
|
|
|
|
|
| |
sem_init() is not functional on Mac OS. Use the Grand Central Dispatch
implementation.
Make libscp_lock.c use semaphores through the thread_calls wrapper.
|
|\
| |
| | |
sesman: do not hardcode Xorg/X11rdp/Xvnc executables
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In RHEL and its clones, /usr/bin/Xorg is set suid-root. To execute
Xorg with user privileges, /etc/pam.d/xserver needs be edited [1],
or suid bit of Xorg binary needs to be dropped.
In order to keep Xorg and /etc/pam.d/xserver untouched, preparing
non-suid version of Xorg as /usr/bin/Xorg.non-suid for example is
the simplest solution. However, Xorg.non-suid cannot be executed
since it is hardcoded to execute Xorg in sesman.
This change makes more flexible to execute Xorg with non-standard
name or not in PATH environment variable.
[1] https://www.centos.org/forums/viewtopic.php?t=21185
|
| | |
|
|/
|
|
| |
it doesn't work on any OS.
|
|
|
|
| |
[-Werror=format-security]"
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Key install (generate rsakeys.ini during make install)
|
| | |
|
| |
| |
| | |
"dist" is ignored in presense of "noinst", so keep noinst_man_MANS.
|
|\ \
| |/
|/| |
pulse: fix build pulseaudio 6.0 or higher
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Discovered in #321. The number of argument for pa_rtpoll_run have
been changed since 6.0.
>=6.0 : int pa_rtpoll_run(pa_rtpoll *f);
<6.0 : int pa_rtpoll_run(pa_rtpoll *f, bool wait);
Check pulseaudio version by PA_CHECK_VERSION macro introduced since
pulseaudio 0.9.16. In case PA_CHECK_VERSION is not defined,
pa_rtpoll_run takes 2 arguments.
|
|/
|
|
| |
There should be no functional difference.
|
|
|
|
| |
Don't mark password as mandatory, it's asked if not provided on the
command line.
|
| |
|
|
|
|
|
|
|
| |
tm_mon in `struct tm` uses 0 for January.
`struct session_data` and `struct SCP_DISCONNECTED_SESSION` don't specify
how dates are stored. But considering the code in sestest and sesadmin,
all date components are stored as displayed.
|
|
|
| |
Other programs typically use the same case as their execulables.
|
|
|
|
|
|
|
| |
libdir is for shared and static libraries. Some xrdp libraries are loaded
dynamically from a non-standard directory, so they are used like modules.
Having separate libdir and moduledir would eventually allow to separate
dynamically loaded modules from shared libraries.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That can cause unexpected behavior, especially with third party tools.
The ignored files will be lost if the source tree is re-imported to
another git repository, unless special care is taken.
Whitelist all non-generated makefiles.
To whitelist instfiles/pam.d/xrdp-sesman, add path to all generated
executables listed in the top-level .gitignore, sort .gitignore
alphabetically.
Add mkinstalldir, it's used by Automake on some systems.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Strictly speaking, both existence and readability should be checked.
However, chances of ~/.profile being a directory or a FIFO are very small
compared to its chances of being non-readable due to some
misconfiguration.
Put "if" and "then" on the same line for consistency with other checks.
Improve comment and pseudocode formatting.
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Fixes for autotools, compile warnings and MacOS compatibility
|
| |
| |
| |
| |
| | |
Notes about software design should not be shown as warnings to everybody
who compiles the code. Warnings should be about unexpected conditions
detected at the compile time.
|
| | |
|
| |
| |
| |
| | |
Arguments without a type default to int. The caller passes a pointer to
XEvent, so use that type.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Use AC_PATH_XTRA to search for X11 in configure.ac. In Makefiles, add
X_CFLAGS to AM_CFLAGS for the source compilation. Add X_LIBS to LDFLAGS.
Add X_PRE_LIBS and X_EXTRA_LIBS to LDADD.
With this patch, X Windows system is correctly detected on Mac OS X.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
AM_CPPFLAGS is for flags passed to the preprocessor, such as defines and
includes. AM_CFLAGS is for flags affecting the compiler, such as debug
and optimization settings.
INCLUDES is an obsolete name. Users can pass INCLUDES and break
compilation. AM_CPPFLAGS is more explicit that the flags come from
Automake and should not be overridden.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Absolute symlinks break when the source is moved to another location. In
the best case, the symlink will be replaced with a copy, but that creates
code duplication. A user who got the packaged source may decide to change
one config.c without realizing that another config.c will get the same
changes.
Don't ignore config.c, it's a regular source file now, albeit very
short.
Testing done: compiled inside and outside build directory.
|