summaryrefslogtreecommitdiffstats
path: root/sesman
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #454 from metalefty/change-chansrv-log-pathmetalefty2016-11-071-0/+40
|\ | | | | chansrv: change chansrv log path to ${XDG_DATA_HOME}/xrdp
| * chansrv: change chansrv log path to ${XDG_DATA_HOME}/xrdpKoichiro IWAO2016-10-251-0/+40
| | | | | | | | | | | | | | like Xorg's logfile is written to ${XDG_DATA_HOME}/xorg/Xorg.n.log. If XDG_DATA_HOME is not defined, the log path will be ${HOME}/.local/share/xrdp.
* | Move -logfile /dev/null option for easier commenting in debug scenarios.Dominik George2016-10-281-6/+6
|/
* Fix memory leak in xrdp-sesman on config reloadPavel Roskin2016-10-213-0/+22
|
* Memory leak fix: keep X server path in the parameter listPavel Roskin2016-10-211-6/+3
| | | | | | | | | | | g_cfg->xorg_params, g_cfg->vnc_params and g_cfg->rdp_params don't have auto_free enabled, so removing an item from one of those lists won't free its contents. It's better not to change those lists, as they represent the actual config file and could be reused. Instead, omit the 0th parameter (the executable path) from copying to xserver_params. Found by Valgrind.
* Call auth_end() exactly once in scp_v0_process()Pavel Roskin2016-10-211-5/+1
| | | | As discovered by Valgrind, it wasn't called at all in case of a successful session creation, which leaked memory.
* Fix memory leak: free session dataPavel Roskin2016-10-214-10/+8
| | | | | | | Call scp_session_destroy() in the functions that call scp_session_create() and nowhere else. As found by Valgrind, the session data is not freed if the session is created successfully.
* Get rid of EXTRA_LIBS, use variables with more specific namesPavel Roskin2016-10-201-6/+6
|
* Eliminate EXTRA_FLAGS, it's a poor name, use AM_LDFLAGSPavel Roskin2016-10-201-3/+1
|
* Merge EXTRA_DEFINES and EXTRA_INCLUDES into AM_CPPFLAGSPavel Roskin2016-10-201-14/+10
| | | | | | | | | | AM_CPPFLAGS is a documented Automake variable for C preprocessor flags that should not be overridden when compiling the package. There is no need to have two additional variables that are ultimately merged into AM_CPPFLAGS. Their names are also confusing. EXTDA_DIST is a documented Automake variable. Everything else that starts with "EXTRA" is not.
* Use const pointers in function arguments when possiblePavel Roskin2016-10-1712-26/+28
|
* Fix wrong comments in sesman config printing codePavel Roskin2016-10-171-4/+4
|
* Fix incorrect description of auth_userpass() return valuePavel Roskin2016-10-171-1/+1
|
* Don't use final newline in log calls, it's already appendedPavel Roskin2016-10-174-11/+11
|
* Log malloc errors with LOG_LEVEL_ERRORPavel Roskin2016-10-172-2/+2
|
* Don't close socket in scp_process_start(), the caller closes itPavel Roskin2016-09-081-1/+0
|
* g_term_event is a wait object, not TCP socket, delete it correctlyPavel Roskin2016-09-081-1/+1
|
* sesrun: remove unused g_sck and write-only g_pidPavel Roskin2016-09-081-4/+0
|
* sesman: don't close listening socket in signal handlerPavel Roskin2016-09-081-2/+0
| | | | It is closed when the main loop terminates.
* chansrv: pathname also should be URL decodedKoichiro IWAO2016-08-301-0/+1
| | | | | | | | because 1st argument to clipboard_get_file() is given as URL encoded. Decoding only filename is incomplete. Without this fix, clipboard file doesn't work in case pathname contains non-ASCII characters or non-alphanumeric ASCII characters.
* Merge pull request #390 from proski/june21jsorg712016-08-0533-197/+114
|\ | | | | Cleanups and C++ compatibility
| * Use enum logLevels consistently for log levelsPavel Roskin2016-07-082-6/+6
| |
| * Fix return type of devredir_fuse_data_peek and devredir_fuse_data_dequeuePavel Roskin2016-07-082-4/+4
| |
| * Use cast when applying boolean OR to enumPavel Roskin2016-07-081-1/+3
| |
| * Fix signed to unsigned comparisons reported by g++ 6.1.0Pavel Roskin2016-07-086-11/+13
| |
| * Use g_new or g_new0 when C++ compiler would complain about implicit castPavel Roskin2016-07-0813-21/+25
| |
| * Cast appdata_ptr explicitly, needed for C++ compatibilityPavel Roskin2016-07-081-2/+2
| |
| * Mark g_drdynvc_chan_id as extern in g_drdynvc_chan_id, it's in chansrv.cPavel Roskin2016-07-081-1/+1
| |
| * Use const unsigned for hex arraysPavel Roskin2016-07-082-3/+3
| | | | | | Some constants are too big for the signed type.
| * Fix warnings detected by -Wwrite-stringsPavel Roskin2016-07-0810-32/+35
| |
| * Make program_name constant, don't duplicate or free itPavel Roskin2016-07-082-2/+2
| |
| * Remove commented out config_read_logging(), the code is long deadPavel Roskin2016-07-081-55/+0
| |
| * Remove unused string support in scp_session_set_addr()Pavel Roskin2016-07-085-44/+6
| | | | | | | | | | | | | | | | Using the same argument for binary and text data is not a good idea. If string support is ever needed, it should be a separate function. Remove SCP_ADDRESS_TYPE_IPV4_BIN and SCP_ADDRESS_TYPE_IPV6_BIN, use SCP_ADDRESS_TYPE_IPV4 and SCP_ADDRESS_TYPE_IPV6, which simplifies the code.
| * Downgrade "libscp initialized" to LOG_LEVEL_DEBUG, remove line numberPavel Roskin2016-07-081-1/+1
| | | | | | | | It's a bad style to start the log with a cryptic warning.
| * Fix scp_init() invocation, it takes no argumentsPavel Roskin2016-07-082-2/+2
| |
| * Fix format warnings in log_message() callsPavel Roskin2016-06-213-4/+4
| |
| * Report pid and listening address/port for xrdp and xrdp-sesmanPavel Roskin2016-06-211-5/+4
| | | | | | | | | | | | For xrdp-sesman, don't report that the daemon is listening to a port if it fails to attach to that port. Don't use LOG_LEVEL_ALWAYS for startup message, it's not a critical error.
| * Rename SESMAN_CFG_X11DISPLAYOFFSET to SESMAN_CFG_SESS_X11DISPLAYOFFSETPavel Roskin2016-06-212-2/+2
| | | | | | | | | | Move it to other session options in config.h. X11DisplayOffset is part of the [Sessions] section.
| * Fix incorrect use of "it's" and "its", adjust wordingPavel Roskin2016-06-211-1/+1
| |
* | Merge pull request #388 from metalefty/freebsd/fusejsorg712016-08-051-1/+1
|\ \ | | | | | | sesman: Add /sbin to PATH for FreeBSD
| * | sesman: Add /sbin to PATH for FreeBSDKoichiro IWAO2016-06-201-1/+1
| |/ | | | | | | | | | | | | | | | | | | | | to enable to execute FUSE mount program. The place of FUSE mount programs are: FreeBSD : /sbin/mount_fusefs GNU/Linux : /bin/fusermount See also #387.
* | Merge branch 'devel' of https://github.com/neutrinolabs/xrdp into develspeidy2016-07-265-35/+667
|\ \
| * | chansrv: avoid chansrv SEGV when xinode is NULLKentaro Hayashi2016-07-212-1/+10
| | | | | | | | | | | | | | | | | | | | | When xfuse_create_file_in_xrdp_fs is failed, it returns NULL. Without this fix, xinode->size causes SEGV, so implementation is changed to return -1 and check the return value in caller.
| * | chansrv: added mp3 compression from SpeidyJay Sorg2016-07-133-34/+657
| |/
* | sesman: env_set_user, fix potential bof issuesspeidy2016-07-223-29/+71
|/
* Remove unused variable in devredir_cvt_from_unicode_len()Pavel Roskin2016-05-061-2/+1
|
* Remove unused variables from dev_redir_proc_query_dir_response()Pavel Roskin2016-05-061-15/+5
|
* Check XGetWindowProperty() return code in clipboard_event_property_notify()Pavel Roskin2016-05-061-0/+10
|
* Use better symbols to protect include filesPavel Roskin2016-05-052-4/+4
|
* Typo fixesPavel Roskin2016-05-045-5/+5
|