diff options
author | Alexander Golubev <fatzer2@gmail.com> | 2024-02-15 22:22:35 +0300 |
---|---|---|
committer | TDE Gitea <gitea@mirror.git.trinitydesktop.org> | 2024-02-16 09:33:12 +0000 |
commit | f34601e77a6960ffe67bef5436063fe3605987c6 (patch) | |
tree | 018a362d0667ce1250c8eaede707bca8957fa299 /tdeio | |
parent | 2c18d241d85fd09c72dc219c8816275c3e7cd59a (diff) | |
download | tdelibs-f34601e77a6960ffe67bef5436063fe3605987c6.tar.gz tdelibs-f34601e77a6960ffe67bef5436063fe3605987c6.zip |
tdeio/kdirlister: add some cleanups for LocalURLJob's
Theoretically the lack of those could lead to segfaults and data
corruptions, hard to debug but very rare.
Signed-off-by: Alexander Golubev <fatzer2@gmail.com>
Diffstat (limited to 'tdeio')
-rw-r--r-- | tdeio/tdeio/kdirlister.cpp | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/tdeio/tdeio/kdirlister.cpp b/tdeio/tdeio/kdirlister.cpp index bcebb93ee..c3fa3d451 100644 --- a/tdeio/tdeio/kdirlister.cpp +++ b/tdeio/tdeio/kdirlister.cpp @@ -1998,6 +1998,11 @@ void KDirLister::stop() { kdDebug(7003) << k_funcinfo << endl; s_pCache->stop( this ); + for( auto it = d->openURLContext.begin(); it != d->openURLContext.end(); ++it ) { + it.key()->disconnect( this ); + it.key()->kill(); + } + d->openURLContext.clear(); d->m_referenceURLMap.clear(); } @@ -2005,6 +2010,17 @@ void KDirLister::stop( const KURL& _url ) { kdDebug(7003) << k_funcinfo << _url.prettyURL() << endl; s_pCache->stop( this, _url ); + TQPtrList<TDEIO::Job> toRemove; + for( auto it = d->openURLContext.begin(); it != d->openURLContext.end(); ++it ) { + if( it.data().url ==_url ) { + it.key()->disconnect( this ); + it.key()->kill(); + toRemove.append(it.key()); + } + } + for(const auto &job: toRemove) { + d->openURLContext.remove(job); + } d->m_referenceURLMap.remove(_url.url()); } |